In 2.6.22 onwards (since git commit 27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26),
on 64bit archs, skb->tail is no more a pointer, but just an offset from
skb->head, and an appropriate wrapper (skb_tail_pointer(skb)) must be used.

See the following snippet from include/linux/skbuff.h:

#ifdef NET_SKBUFF_DATA_USES_OFFSET
static inline unsigned char *skb_tail_pointer(const struct sk_buff *skb)
{
return skb->head + skb->tail;
}
...

For older kernel releases, an appropriate default definition of the kernel
offset is given in ipw3945.h.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

Index: ipw3945-1.2.2/ipw3945.c
===================================================================
--- ipw3945-1.2.2.orig/ipw3945.c
+++ ipw3945-1.2.2/ipw3945.c
@@ -14928,7 +14928,7 @@ static inline void ipw_build_tx_cmd_hwcr
tx_cmd->sec_ctl = TX_CMD_SEC_TKIP;

if (last_frag)
-			memcpy(tx_cmd->tkip_mic.byte, skb_frag->tail - 8, 8);
+			memcpy(tx_cmd->tkip_mic.byte, skb_tail_pointer(skb_frag) - 8, 8);
else
memset(tx_cmd->tkip_mic.byte, 0, 8);

Index: ipw3945-1.2.2/ipw3945.h
===================================================================
--- ipw3945-1.2.2.orig/ipw3945.h
+++ ipw3945-1.2.2/ipw3945.h
@@ -76,6 +76,13 @@ typedef void irqreturn_t;
#include <linux/mutex.h>
#endif

+#if ( LINUX_VERSION_CODE < KERNEL_VERSION(2,6,22) )
+static inline unsigned char *skb_tail_pointer(const struct sk_buff *skb)
+{
+	return skb->tail;
+}
+#endif
+
#if !defined(CONFIG_SOFTWARE_SUSPEND2_BUILTIN) && \
(defined(CONFIG_SOFTWARE_SUSPEND2) || \
defined(CONFIG_SOFTWARE_SUSPEND2_MODULE))

Since we have already store the inta to priv->isr_inta in the
interrupt handler we don't need to get it from the hardware again
in the tasklet. Some people find ipw3945-1.2.1 still didn't
resolve the boot lockup problem as reported in bugzilla #1096.

If you still find the lockup problem in ipw3945-1.2.1, please try
this patch and report if it resolves your problem or not to
yi.zhu@intel.com.

Thanks to Egon for providing this patch!

Signed-off-by: Egon <anannatrak@yahoo.it>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
--

--- a/ipw3945.c	2007-04-11 14:46:58.000000000 +0800
+++ b/ipw3945.c	2007-05-14 15:55:56.000000000 +0800
@@ -2769,8 +2769,8 @@ static void ipw_irq_tasklet(struct ipw_p

spin_lock_irqsave(&priv->lock, flags);

-	inta = ipw_read32(priv, CSR_INT);
-	inta_mask = ipw_read32(priv, CSR_INT_MASK);
+	inta = 0;
+	inta_mask = 0;
ipw_write32(priv, CSR_INT, inta);
inta &= (CSR_INI_SET_MASK & inta_mask);

Change call to the deprecated pci_driver_init to pci_register_driver.

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
ipw3945.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Hi,

On a Fedora Core 6 box (WE-20) with wireless-tools both v28 and v29 I’m
seeing a bogus character appended to ESSID on iwconfig output since
ipw3945-1.1.2.

The reason seems to be the patch in bug #1146, which I guess has a typo
that attached patch fixes.

~sertaç

--

diff -Nupr ipw3945/ipw3945.c ipw3945-new/ipw3945.c
--- ipw3945/ipw3945.c	2006-12-08 19:33:45.000000000 +0200
+++ ipw3945-new/ipw3945.c	2006-12-15 01:08:29.000000000 +0200
@@ -12210,7 +12210,7 @@ static int ipw_wx_get_essid(struct net_d
IPW_DEBUG_WX("Getting essid: '%s'\n",
escape_essid(priv->essid, priv->essid_len));
memcpy(extra, priv->essid, priv->essid_len);
-		wrqu->essid.length = priv->essid_len + IW_ESSID_FIX;
+		wrqu->essid.length = priv->essid_len;
wrqu->essid.flags = 1;	/* active */
} else {
IPW_DEBUG_WX("Getting essid: ANY\n");

Delayed works and normal works have been split to allow smaller memory
usage. Use struct delayed_work where necessary.

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
ipw3945.c |  106 +++++++++++++++++++++++++++++++++----------------------------
ipw3945.h |   27 ++++++++-------
2 files changed, 71 insertions(+), 62 deletions(-)

INIT_WORK now takes 2 arguments and we can get the user data through the
container_of macro.

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
ipw3945.c |  198 ++++++++++++++++++++++++++++++-------------------------------
1 files changed, 98 insertions(+), 100 deletions(-)